-
Notifications
You must be signed in to change notification settings - Fork 1
Joo/#11/create game detail cells #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ohdair
wants to merge
19
commits into
main
Choose a base branch
from
joo/#11/create-game-detail-cells
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 타입에 맞는 title과 information을 적는 Label로 구성
- 각 타입마다 InformationView로 표현되도록 설정
- 기존 코드에서는 추가가 되지 않은 상황 - dataSource 소유를 명시
- 게임 정보를 기반으로 Information에 해당하는 Section을 표현하도록 구현
Conflicts: GameScope/GameScope.xcodeproj/project.pbxproj
- generateImageLayout 메서드 추가 - GameDetailImageCell 등록 및 구성하도록 추가
- 문자열로 이뤄진 url을 통해 Image를 받는 dispatchImage 추가
- Cell 선택시 json 파일을 통한 정보를 보여주도록 설정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11 게임 설명을 보여주는 Cell 및 관련 정보를 보여주는 Cell 추가
#12 게임 이미지(thumbnail, screenshot) 보여주는 Cell 추가