Skip to content

Refactor MeshHelper #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Refactor MeshHelper #335

wants to merge 3 commits into from

Conversation

isHarryh
Copy link
Contributor

Summary

This PR does some improvements to MeshHelper.

  1. Making flat_list_to_tuples an inline function.
  2. Introduces the lists_to_tuples function to fix the type error that List[List] produced by the zeros function cannot be assigned to tuple-member-lists such as List[Tuple3f] List[Tuple4f].
  3. Refactors the get_triangles function.
    1. Changes the way to generate triangles lists.
    2. Adds a indexCount fix for TriangleStrip submeshes, see AssetStudio's code.
    3. Removes the TODOs in the get_triangles function (I have tested that using NumPy as_strided function cannot realize a speed-up).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant