Skip to content

Fix ghost blocks caused by leftover extended IDs #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KAMKEEL wants to merge 1 commit into
base: kawe
Choose a base branch
from
Open

Fix ghost blocks caused by leftover extended IDs #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions forge1710/src/main/java/com/boydti/fawe/forge/v1710/ForgeChunk_All.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,14 @@ public void setBlock(int x, int y, int z, int id, int data) {
extended[i] = nibble = new NibbleArray(4096, 4);
}
nibble.set(x, y & 15, z, id >> 8);
} else {
// Clear MSB when placing blocks without extended IDs to avoid
// leftover values causing ghost blocks. TODO: ensure extended data
// is reset for non-extended block changes.
NibbleArray nibble = extended[i];
if (nibble != null) {
nibble.set(x, y & 15, z, 0);
}
}

}
Expand Down