-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade urllib3 from 2.0.7 to 2.5.0 #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KB01111
wants to merge
1
commit into
main
Choose a base branch
from
snyk-fix-eb1dc00c732bcc064039f0e552103408
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading
urllib3to version2.5.0(or newer, as specified by>=2.5.0) is a positive step for security by addressing known vulnerabilities.However, it's crucial to address the critical dependency warnings highlighted by Snyk in the PR description. These include:
httpx: Several packages (e.g.,supafunc,supabase,storage3,postgrest-py,gotrue) requirehttpx <0.24.0, but version0.24.1is reported as present.pydantic:postgrest-pyandgotruerequirepydantic <2.0.0, but version2.5.3is reported.websockets:realtimerequireswebsockets <11.0, but11.0.3is reported.typing-extensions:openairequirestyping-extensions >=4.11, but4.7.1is reported (this is an older version than required).jiter(required byopenaiandanthropic).tokenizers(required byanthropic).These conflicts and missing dependencies can lead to runtime errors or unexpected behavior and must be resolved before this change is merged. This may involve:
requirements.txtto ensure compatibility (e.g., pinninghttpx,pydantic,websockets,typing-extensionsto versions that satisfy all constraints, or upgrading the packages that depend on them).jiter,tokenizers) torequirements.txt.openai==1.53.1andanthropic==0.38.0(or their current versions) can work with the existingtyping-extensions==4.7.1or iftyping-extensionsneeds an upgrade that doesn't break other packages.Please ensure the entire application is thoroughly tested after resolving these dependency issues to confirm stability and correct functionality.