Conversation
| #give it back to the LLM to try again | ||
| scenic_program = claude_response.completion | ||
| for _ in range(max_compiler_errors): | ||
| success, output = self.run_scenic_program(scenic_program) |
Collaborator
There was a problem hiding this comment.
Note for later: once we update the Scenic compiler stage used should make sure this is consistent with it
src/scenicNL/common.py
Outdated
| try: | ||
| # Using subprocess.run to execute the command | ||
| # The command will run for up to 10 seconds | ||
| result = subprocess.run(['scenic', temp_file_name, '--2d'], |
Collaborator
There was a problem hiding this comment.
Same comment as before @devanshanker switch this to ast/compilation so filenames/etc. don't trigger errors
| return False, result.stdout.decode() | ||
|
|
||
| except subprocess.TimeoutExpired: | ||
| # If the command times out after 10 seconds |
Collaborator
There was a problem hiding this comment.
Once we switch this to compilation instead of execution we can cut the delay since it compiles ~instantly
devanshanker
approved these changes
Jan 25, 2024
Collaborator
devanshanker
left a comment
devanshanker
left a comment
There was a problem hiding this comment.
Good looks much cleaner than what i had
…tter results this way) 2. Add complier feedback loop 3. Code to remove LLM "helpful" jiberish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still need to run tests, check.sh, and add the GPT side