Open
Conversation
KE7
commented
Mar 7, 2024
|
|
||
| def __init__(self): | ||
| super().__init__() | ||
| openai.api_base = "http://localhost:8080/v1" |
Owner
Author
There was a problem hiding this comment.
I will hate myself for starting like this but I am just trying to go ><
If we do grammar constraints this wont work. If we do LMQL constraints, this might work?
Collaborator
There was a problem hiding this comment.
Can you explain the distinction when we meet
devanshanker
reviewed
Mar 7, 2024
| continue | ||
|
|
||
| # we could not compile the program so we just return our best effort | ||
| # TODO: do a GPT-Judge thing here and ask which was the best then return that one? |
Collaborator
There was a problem hiding this comment.
Good TODO want to make sure it doesn't get lost in the PR
devanshanker
approved these changes
Mar 7, 2024
Collaborator
devanshanker
left a comment
There was a problem hiding this comment.
Good looks, we should make sure the methodology and instructional/ToT Q/A process is consistent across local models and API (at least to the extent that context lengths / LMQL allow)
devanshanker
reviewed
Mar 7, 2024
| questions = None | ||
| with os.open(PromptFiles.COMPOSITIONAL_GBNF.value) as f: | ||
| prompt = f.read() | ||
| questions = yaml.safe_load(prompt) |
Collaborator
There was a problem hiding this comment.
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.