For pr by psychotrance · Pull Request #111 · KFalcon2022/practical-tasks

psychotrance · 2025-04-18T11:10:03Z

Исправления в Lesson 14-17
Добавил задания из Lesson 18

Task 1 Task 2 Task 3 (Lesson 14 - task2)

src/com/walking/lesson14_polymorphism/task1/Main.java

src/com/walking/lesson17_enum/task1/answer/Answer.java

src/com/walking/lesson17_enum/task2/model/Animal.java

src/com/walking/lesson17_enum/task3/model/DataRequire.java

src/com/walking/lesson17_enum/task3/model/EquiliteralShape.java

src/com/walking/lesson14_polymorphism/task1/model/RegularFigure.java

src/com/walking/lesson17_enum/task1/answer/Answer.java

src/com/walking/lesson18_instanceof_getClass/task1_getClass/Main.java

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

AVL_Tree: not ended(plz check) AVL_tree_2: from youtube with correction Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

src/com/walking/lesson37_collection_list/task1/service/CounterService.java

src/com/walking/lesson38_comparing/task2/model/CarIdentifier.java

src/com/walking/lesson42_tree/task1_easy/structure/UnbalancedBinaryTree.java

src/com/walking/lesson42_tree/task1_hard/structure/BinarySearchTree.java

src/com/walking/lesson43_map/task1/Main.java

src/com/walking/lesson43_map/task1/exception/RegexValidationException.java

src/com/walking/lesson43_map/task2/Main.java

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

src/com/walking/lesson46_lambda/task3/domain/filter/CarColorFilter.java

src/com/walking/lesson46_lambda/task3/Main.java

src/com/walking/lesson47_method_reference/task1/Main.java

src/com/walking/lesson47_method_reference/task2/Main.java

src/com/walking/lesson47_method_reference/task3/service/MenuService.java

src/com/walking/lesson49_optional/task2/service/FirstChildCarOwnerAddressService.java

src/com/walking/lesson49_optional/task2/service/AddressService.java

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

… он имелся ввиду Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

check code format, plz) Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

KFalcon2022 · 2026-02-18T17:55:46Z

src/com/walking/lesson52_stream_creation/task1/Main.java

+        Scanner scanner = new Scanner(System.in);
+        Stream.generate(scanner::nextInt)
+                .takeWhile(num -> num != 1)
+                .forEach(_ -> System.out.println("Not guess!"));


а как понять, что выиграл?)

Я, конечно же, написал после выполнения стрима system.out.println("Guess"), но это видимо не то, что ты хотел мне донести, по этому хелп)

KFalcon2022 · 2026-02-18T17:57:12Z

src/com/walking/lesson57_stream_collect_collector/model/Employee.java

+
+    @Override
+    public boolean equals(Object o) {
+        if (o == null || getClass() != o.getClass()) return false;


фуфуфу

Убрал)

KFalcon2022 · 2026-02-18T17:57:36Z

src/com/walking/lesson57_stream_collect_collector/task/Task1.java

-        return null;
+        return departments.stream()
+                .flatMap(dep -> dep.getEmployees().stream())
+                .collect(Collectors.toList());


думаешь, нам нужен изменяемый список?

KFalcon2022 · 2026-02-18T17:58:15Z

src/com/walking/lesson57_stream_collect_collector/task/Task11.java

+        return departments.stream()
+                .flatMap(department -> department.getEmployees().stream())
+                .collect(Collectors.groupingBy(Employee::getName,
+                        TreeMap::new,


избыточно

Я не понимаю, что именно избыточно, по этому прошу помощи
Если TreeMap:new убрать, IDEA пугается на несоответствующий возвращаемый тип

KFalcon2022 · 2026-02-18T18:00:33Z

src/com/walking/lesson57_stream_collect_collector/task/Task15.java

+                                        .stream(),
+                                Collectors.teeing(
+                                        Collectors.filtering(Employee::isMale,
+                                                Collectors.toList()),


Collectors.counting()? Нам список не нужен

KFalcon2022 · 2026-02-18T18:12:41Z

src/com/walking/lesson57_stream_collect_collector/task/Task23.java

+                ));
+
+        /* Я другие варианты как выполнить это задание не нашел.
+         * Но если есть - дай намёк, пж) */


https://github.com/KFalcon2022/practical-tasks/blob/master/src/com/walking/lesson57_stream_collect_collector/task/Task23.java

Иногда проще выйти за пределы стрима. В остальном - идея верная

Принято, спасибо)

KFalcon2022 · 2026-02-18T18:26:36Z

src/com/walking/lesson57_stream_collect_collector/task/Task4.java

-        return null;
+        return departments.stream()
+                .sorted(Comparator.comparing(Department::getName))
+                .collect(LinkedList::new,


Чем обычный список не устроил?

Ну в задании же конкретно LinkedList вернуть надо)
Или я снова что-то не понимаю?)

KFalcon2022 · 2026-02-18T18:27:57Z

src/com/walking/lesson57_stream_collect_collector/task/Task6.java

+        return departments.stream()
+                .collect(Collectors.toMap(Department::getName,
+                        department -> ((double) department.getEmployees()
+                                .size() / department.getVacancyAmount()) * 100));


Делимое и делитель местами перепутал. И перенос строки неудачный

KFalcon2022 · 2026-02-18T18:29:24Z

src/com/walking/lesson58_collection_lamda_param/task1/Main.java

    public static void main(String[] args) {
    }
+
+    private static Map<String, Employee> getOldestEmployees(List<Department> departments) {


Боюсь, это была задачка на Map#compute()

KFalcon2022 · 2026-02-18T18:30:11Z

src/com/walking/lesson58_collection_lamda_param/task3/Main.java

+        Map<String, Integer> sumAges = new HashMap<>();
+        employees.forEach(employee -> {
+            sumAges.putIfAbsent(employee.getName(), 0);
+            sumAges.computeIfPresent(employee.getName(), (key, age) -> age + employee.getAge());


решается через один compute

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

psychotrance added 6 commits April 18, 2025 22:30

Lesson 14 task1-2

bf86994

Lesson 14 task1

4174204

Lesson 14 task2

a8ef03f

Lesson 16

33d9f6a

Task 1 Task 2 Task 3 (Lesson 14 - task2)

Lesson 17 task 1 - 3

f7e44ea

Lesson 18 task 1 - 2

40816a9

KFalcon2022 reviewed Apr 22, 2025

View reviewed changes

psychotrance closed this Apr 23, 2025

psychotrance reopened this Apr 23, 2025

psychotrance added 2 commits April 23, 2025 17:40

Lessons 14-17 Corrections

fdfa697

Lessons 14-17 Corrections

4717c4e

KFalcon2022 reviewed Apr 29, 2025

View reviewed changes

src/com/walking/lesson14_polymorphism/task1/model/RegularFigure.java Outdated Show resolved Hide resolved

KFalcon2022 reviewed Apr 29, 2025

View reviewed changes

src/com/walking/lesson17_enum/task1/answer/Answer.java Outdated Show resolved Hide resolved

KFalcon2022 reviewed Apr 29, 2025

View reviewed changes

src/com/walking/lesson18_instanceof_getClass/task1_getClass/Main.java Outdated Show resolved Hide resolved

KFalcon2022 reviewed Apr 29, 2025

View reviewed changes

src/com/walking/lesson18_instanceof_getClass/task1_getClass/Main.java Show resolved Hide resolved

psychotrance added 15 commits April 30, 2025 16:25

Lesson 20 task1_catchException

42f3661

Lesson 20 task1_throwsException

1f5b9df

Changes after threads)

694d1f1

Changes after threads)

c0dc663

Lesson 20 task 2-3

b244003

Lesson 21 task1

f74c5ff

Lesson 25 task1-2(anonymous_class)

91a1edc

Lesson 25 task1-2(inner_class)

a1d2b21

Lesson 25 task1-2(static_class)

3da4977

Lesson 25 task1-2(static_class)

4c13381

Lesson 25 task1-2(static_class)

fead10a

Lesson 26 task1

3842b90

Lesson 26 task1

2eddc7d

Lesson 26 task2

349fc6b

Lesson 26 task2

cfd6e6e

psychotrance added 10 commits January 4, 2026 14:44

Lesson 42 task1_hard

cf24fcf

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Lesson 42 task1_hard

8ff8b93

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Lesson 42 task2 Adding+treeLvl Done!

bdf91fb

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Lesson 42 task2 Adding+treeLvl Done!

5664328

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Lesson 42 task2

79138d7

AVL_Tree: not ended(plz check) AVL_tree_2: from youtube with correction Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Lesson 43 task1

9131206

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Lesson 43 task2

d1aa1bc

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Lesson 46 task1

64ec2a0

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Lesson 46 task2

f1c4f8a

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Lesson 46 task2

d376722

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

KFalcon2022 reviewed Jan 11, 2026

View reviewed changes

psychotrance added 9 commits January 12, 2026 22:17

Lesson 38-45 pr-changes

667fd59

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Lesson 38-45 pr-changes

8568649

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Lesson 46 task 1-2 (task 3 is yours)

e21555c

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Lesson 47 task 1-3

78f105c

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Lesson 49 task 1

1936c61

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Lesson 49 task 3

b025073

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Lesson 49 task 3

2599d34

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Lesson 49 task 2

58dce22

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Lesson 49 task 2

695b49c

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

KFalcon2022 reviewed Feb 1, 2026

View reviewed changes

psychotrance added 6 commits February 2, 2026 13:21

Lessons 46-49 pr-changes

32f9d83

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Lesson 52 task 1-2 (3rd won't be)

0e3ec48

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Я так и не понял, как тут воспользоваться finiser() в конце, если тут…

07cca6c

… он имелся ввиду Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Lesson 57 tasks 1-24

6202e2b

check code format, plz) Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Lesson 58 task 1-3

d226ab4

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Lesson 60 task1

533095d

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

KFalcon2022 reviewed Feb 18, 2026

View reviewed changes

psychotrance added 2 commits February 20, 2026 06:39

lessons 52-58 PR changes

688a4db

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

lessons 52-58 PR changes

5839bcd

Signed-off-by: AlexeyNiyazov <psychotrance92@yandex.ru>

Conversation

psychotrance commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

psychotrance commented Apr 18, 2025 •

edited

Loading