Skip to content

fix: resolve duplicate get_checkpoint_serves method from merge conflicts#23

Merged
KHAEntertainment merged 1 commit intomasterfrom
fix/merge-conflict-core
Mar 27, 2026
Merged

fix: resolve duplicate get_checkpoint_serves method from merge conflicts#23
KHAEntertainment merged 1 commit intomasterfrom
fix/merge-conflict-core

Conversation

@KHAEntertainment
Copy link
Copy Markdown
Owner

@KHAEntertainment KHAEntertainment commented Mar 27, 2026

Cleans up overlapping code introduced during the batch PR merges. Removes the duplicate _ensure_serve_records_table and get_checkpoint_serves(Optional) which conflicted with the newer token-based checkpoint serving logic. Tests are now passing locally.

Summary by CodeRabbit

  • Refactor
    • Removed legacy checkpoint serve records functionality, including automatic database table creation and associated query methods that are no longer needed by the system.
  • Tests
    • Updated test cases to properly validate changes to the checkpoint serve record functionality.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: abcc7433-e790-453a-b0c9-504e42862792

📥 Commits

Reviewing files that changed from the base of the PR and between b19c03d and a101432.

📒 Files selected for processing (2)
  • src/ocbs/core.py
  • tests/test_core.py
💤 Files with no reviewable changes (1)
  • src/ocbs/core.py

Walkthrough

The changes remove legacy checkpoint serve records functionality from the OCBS core module, including the _ensure_serve_records_table() function and the get_checkpoint_serves() method that previously managed a deprecated serve_records table schema. Corresponding test assertions are updated to reflect these removals.

Changes

Cohort / File(s) Summary
Legacy Serve Records Removal
src/ocbs/core.py
Removed _ensure_serve_records_table() function and get_checkpoint_serves() method that handled the deprecated serve_records table with checkpoint/backup tracking.
Test Alignment
tests/test_core.py
Updated test_get_checkpoint_serves_handles_missing_table to pass explicit checkpoint identifier parameter and assert empty list behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🗑️ Legacy code takes its final bow,
The serve records table says goodbye now,
Old schemas fade like morning dew,
Tests aligned with what is true,
Clean code emerges, fresh and bright! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change—removing duplicate legacy methods that conflicted during merges—which aligns with the actual code removal in the changeset.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/merge-conflict-core

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@KHAEntertainment KHAEntertainment merged commit 9c7357f into master Mar 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant