fix: address PR review comments — agent plugin correctness, shell injection, datetime safety, Pattern 3 parsing#18
Merged
KHAEntertainment merged 2 commits intoclaude/review-open-issues-RBCujfrom Mar 21, 2026
Conversation
6 tasks
Co-authored-by: KHAEntertainment <43256680+KHAEntertainment@users.noreply.github.com> Agent-Logs-Url: https://github.com/KHAEntertainment/grok-multiagent-plugin/sessions/2dc54b6f-c039-4e6b-8100-e7a374c6c952
Copilot
AI
changed the title
[WIP] Fix issues #14, #12, #11, and #16
fix: address PR review comments — agent plugin correctness, shell injection, datetime safety, Pattern 3 parsing
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies all outstanding review comments from PR #17 across the plugin, bridge, and agent layers.
src/plugin/index.tsasync(required for top-levelawait import)./grok_agent_plugin.js→./grok_agent_pluginsrc/plugin/grok_agent_plugin.tsPLUGIN_ROOTfixed: was walking 3 dirs up (past repo root), now 2api.config?.agentScriptpath — not inconfigSchemaandadditionalProperties: falseblocked it anywayargs.push("--", params.task)→args.push("--task", params.task)(positional not accepted by argparse)api.config?.pythonPathwith"python3"fallback, consistent withindex.tsplatforms/claude/commands/grok-swarm-agent.shARGS+=("$TASK")→ARGS+=("--task" "$TASK")src/agent/grok_agent.py— shell injectionverify_cmdwas run withshell=Trueand user-controlled input; replaced withshlex.split()+shell=Falsesrc/bridge/grok_bridge.py+skills/grok-refactor/bridge/grok_bridge.py— Pattern 3 parsing# filename.extno longer break file extractionsrc/bridge/usage_tracker.py+skills/grok-refactor/bridge/usage_tracker.py— naive datetime crashdatetime.fromisoformat()returns a naive datetime for hand-edited/legacy records; comparing naive to aware raisesTypeError. Now normalizes naive timestamps to UTC before comparison and catchesTypeErrorin the except clause.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.