fix: make plugin entry-point async to permit await import()#22
Merged
KHAEntertainment merged 1 commit intoclaude/review-open-issues-RBCujfrom Mar 21, 2026
Merged
Conversation
6 tasks
Copilot
AI
changed the title
[WIP] [WIP] Address feedback from PR #17 on open issues #14, #12, #11, #16
fix: make plugin entry-point async to permit await import()
Mar 21, 2026
26f8cbf
into
claude/review-open-issues-RBCuj
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
await import("./grok_agent_plugin")was called inside a non-asyncexported function, which is a syntax error in JS/TS.Change
The dynamic import on line 219 is now syntactically valid within the async context.
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.