Draft
Conversation
rflechtner
added a commit
that referenced
this pull request
Nov 7, 2024
Tests currently failing (fix TBD in another PR): - [ ] Team cannot be reset when pool is not live (fixed by #786)
c59b04b to
1ad53b2
Compare
Member
|
@rflechtner What is this? |
Contributor
Author
We can pick this up after trialing the pallet on a testnet. We're currently not quite sure if we want to reset the asset admins when the pool moves to refunding state. This would do it, but would need to be benchmarked properly. |
62680ee to
305e8a7
Compare
fixes audit issue 6
305e8a7 to
59856a5
Compare
Contributor
|
@rflechtner Can we also close this? |
Contributor
Author
Mhh this is something that would still make sense, although I don't see that this gets any priority |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested change to avoid unexpected changes to currencies and issuances while refunding. This resets all asset teams to the pool account when calling
start_refund.This is waiting for a runtime implementation of our new pallet so that we can see the impact on the transaction weight that this has.
Checklist:
array[3]useget(3), ...)