Checking if encodedDetails can be decoded in the parse function#899
Open
MarkusGarmeister wants to merge 1 commit intodevelopfrom
Open
Checking if encodedDetails can be decoded in the parse function#899MarkusGarmeister wants to merge 1 commit intodevelopfrom
MarkusGarmeister wants to merge 1 commit intodevelopfrom
Conversation
Member
Dudleyneedham
left a comment
Dudleyneedham
left a comment
There was a problem hiding this comment.
I think we can use functionality in the library
| const queryParameters = exportQueryParamsFromDidUrl(did as DidUrl) | ||
| // checking if encodedDetails can be decoded | ||
| if (encodedDetails) { | ||
| try { |
Member
There was a problem hiding this comment.
The library has a validation function. We should be able to use that. @rflechtner What do you think?
base58Validate(encodedDetails, true)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#3033
A light DID resolution with encoded details, which can not be decoded, is parsed and decoded twice. I tried to fix this with a check of the encodedDetails in the parse function. However the tests are failling.
Checklist: