Skip to content

Conversation

@keyspace
Copy link

@keyspace keyspace commented Oct 3, 2016

General discussion: #12

Most changes via shell scripts. Therefore monotonic, don't be alarmed by changed file count.

Major:

  • bundled Firespitter DLL for simultaneous fuel/texture switching;
  • added rudimentary Linux Debug build (using MonoDevelop);
  • placed parts in Parts/*, DLL in Plugins (see tree).

Minor:

  • named "combined CO2 + WasteWater + Waste" containers "Refuse" instead of "Waste" in the fuel switch menu (and part filenames) to avoid confusion; actual part names remain the same for compatibility (and to promote confusion);
  • don't show legacy parts in VAB/SPH; won't be shown in Tech Tree, too, unless already unlocked.

TBD:

  • more notes here instead of in-commit;
  • perhaps borrow Firespitter's code instead of including it whole;
  • move WasteContainers to Legacy, too, and add RefuseContainers?..

Part files renamed to `Container{Small,,Large}.cfg`, resource-specific
parts moved to separate directory (`Legacy`).

NOTE: "Waste" containers that previously contained CO2+WasteWater+Waste
have been rebranded "Refuse" to avoid confusion. This happened on the
fuel switch level, the actual Waste.cfg parts are still present (in the
`Legacy` dir.)

TODO: put all resources in tags.
TODO: reorder resources so food-water-oxygen and waste-wastewater-co2
(or reverse).
… list and tech tree.

This only works for new games ATM. Researched and unlocked parts still
show in VAB/SPH and/or tech tree.
This shreds or bypasses some important packaging functionality, mostly
versioning. Needs work by someone more knowledgeable.

There is no .pdb (debug symbols) on Linux, so don't try to copy those.

An .mdb is properly generated by MonoDevelop when launching like this:

KSP='\home\keyspace\ksp\KSP_Data\Managed\' KSP_TEST='\tmp\ksp' monodevelop Source/TacLifeSupport.sln &

`KSP` is a working copy location with all the packages.
`KSP_TEST` is the root dir of the destination copy.

Obviously, they don't have to be the same deployment - helps a lot
if you screw up and need to delete the testing one.

0-error debug build on Linux, with files copied if KSP_TEST given.

P.S. Using MonoDevelop 5.10.1.6.
So everything was in ThunderAerospace, not
ThunderAerospace/TacLifeSupport. :D
Should install to proper dir on Linux now.
Parts already researched _and_ purchased will still be visible in the
tech tree.

Squashed: Revert fudged up hint paths in csproj.
@JPLRepo
Copy link

JPLRepo commented Oct 3, 2016

There are way too many changes in this PR.
Will take some time to look at this.
And I don't agree with using firespitter as a hard dependency.
I also think the community/users of TAC LS should be consulted first as the changes here are drastic.
Also that needs to be considered is what is the impact on other mods such as Realism Overhaul?

@keyspace keyspace changed the title Reduce part count (rebased, example) Reduce part count (rebased, example, WIP) Oct 3, 2016
@keyspace
Copy link
Author

keyspace commented Oct 3, 2016

Post-factum thought: it would have been simpler to move all existing parts to Legacy, and introduce new switchable parts.

Also took a look at RO, where RealFuels is a dependency - so using a full Firespitter is truly out of place. A better approach would be to use a minimal code clone for those that don't use RO, and hand control over to RealFuels otherwise (which is already being done). Part incompatibility is a non-issue in this case, since RO introduces changes so drastic that a new game is a must.

Therefore OK to close IMO.

@JPLRepo
Copy link

JPLRepo commented Oct 4, 2016

Yes old parts should be legacy/still available or old saves get broken.
I will discuss with RO post- 1.2 release as to the best way forward.
I also forgot to mention that really with the Editor Filter that I implemented if this is that necessary as it seems the original motivation was simply that there were a lot of parts in the parts picker/ Utilities section. Parking this until post 1.2

@JPLRepo
Copy link

JPLRepo commented Oct 27, 2016

I have someone currently re-texturing the parts.
Also the format of the TACGenericResourceConverter has changed to stock format.
Some of the other changes are no longer appropriate either as I had already done them. (such as move DLLs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants