Fix some cases where texture replacements were not being applied #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new order is now: - choose by priority, then, - pick the texture that matches the size, otherwise, - pick the unsized texture if available, otherwise, - pick the largest texture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1 introduced a behaviour that we would only replace a texture if either:
This was not intended. This PR fixes that, adds some more logging, and explicitly nails down an order for what replacement is picked if there are multiple ambiguous options.
This should help with part of #9 but doesn't necessarily fix the issue because ZTheme has some ambiguous replacements that are being handled differently.