fix: legacy delegation types

[mbreithecker]

Summary by CodeRabbit

• New Features
  • Introduced support for updating delegation module parameters via a new governance message.
• Chores
  • Enhanced internal message registration to recognize new delegation parameter update messages.

[coderabbitai]

Walkthrough

A new protobuf definition file for the kyve.delegation.v1beta1 package has been introduced, specifying a gRPC service for updating delegation module parameters via governance. The file defines the MsgUpdateParams message, an empty response type, and the associated service. Additionally, the interface registry in the stakers module has been updated to recognize the new MsgUpdateParams message as an implementation of the sdk.Msg interface, ensuring compatibility and correct message handling in the system.

Changes

File(s)	Change Summary
proto/kyve/delegation/v1beta1/tx.proto	Added new protobuf file defining the Msg gRPC service with UpdateParams RPC, and messages for parameter updates.
x/stakers/types/codec.go	Registered MsgUpdateParams from the new delegation package as an implementation of sdk.Msg in the interface registry.

Poem

In fields of code where messages grow,
A new update service now takes its bow.
Protobuf seeds in delegation's land,
With registry tweaks, all goes as planned.
The rabbits rejoice, their tails held high—
For governance flows as updates fly!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b2d39f and 1f11c6f.

⛔ Files ignored due to path filters (1)

• x/stakers/types_delegation_v1beta1/tx.pb.go is excluded by !**/*.pb.go

📒 Files selected for processing (2)

• proto/kyve/delegation/v1beta1/tx.proto (1 hunks)
• x/stakers/types/codec.go (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

x/stakers/types/codec.go (2)

x/stakers/types_delegation_v1beta1/tx.pb.go (3)

• MsgUpdateParams (33-38)
• MsgUpdateParams (42-42)
• MsgUpdateParams (43-45)

x/stakers/types/tx.pb.go (3)

• MsgUpdateParams (429-434)
• MsgUpdateParams (438-438)
• MsgUpdateParams (439-441)

🪛 Buf (1.47.2)

proto/kyve/delegation/v1beta1/tx.proto

5-5: import "cosmos/msg/v1/msg.proto": file does not exist

(COMPILE)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Summary

🔇 Additional comments (8)

proto/kyve/delegation/v1beta1/tx.proto (6)

1-14: Well-defined protobuf file for governance param updates

This new file correctly establishes the necessary structures for delegation module governance parameter updates, maintaining backward compatibility with legacy governance proposals as noted in the comments.

🧰 Tools

🪛 Buf (1.47.2)

5-5: import "cosmos/msg/v1/msg.proto": file does not exist

(COMPILE)

---

8-8: Verify Go package path consistency

The Go package path includes "stakers" (github.com/KYVENetwork/chain/x/stakers/types_delegation_v1beta1) for a delegation module proto file. This seems intentional based on the codec registration in x/stakers/types/codec.go, but it's worth confirming this architecture decision follows your project conventions.

---

18-24: Properly defined Msg service with governance controls

The service correctly uses the cosmos.msg.v1.service option and properly documents that the governance module account has authority over parameter updates.

---

26-34: Well-structured MsgUpdateParams message

The message definition follows Cosmos SDK conventions with proper use of:

• cosmos.msg.v1.signer option for the authority field
• cosmos_proto.scalar annotation for the address string
• Clear documentation of field purposes

---

36-37: Empty response message follows convention

The empty MsgUpdateParamsResponse message follows standard Cosmos SDK patterns for parameter update operations.

---

5-5:

Details

❓ Verification inconclusive

Verify the import path resolves correctly

The static analysis tool flagged that "cosmos/msg/v1/msg.proto" doesn't exist, but this is likely a false positive since this is a standard Cosmos SDK proto import.

---

🏁 Script executed:

#!/bin/bash
# Check if the import resolves correctly in the project environment
find . -path "*/vendor/cosmos/msg/v1/msg.proto" -o -path "*/third_party/cosmos/msg/v1/msg.proto" | grep -q . && \
  echo "Import file exists" || echo "Import file not found"

Length of output: 163

---

We should check the entire repository for this proto rather than only vendor paths. Let’s search across all dirs:

---

🏁 Script executed:

#!/bin/bash
# Search for the imported proto file in the entire repo
find . -type f -path "*cosmos/msg/v1/msg.proto"

Length of output: 49

---

Confirm Cosmos SDK proto import path

I couldn’t locate cosmos/msg/v1/msg.proto in the repository. This import is provided by the Cosmos SDK’s proto definitions—please verify that your code-generation toolchain (e.g. buf, protoc include paths, or vendored proto files) includes the Cosmos SDK protos so that this path resolves correctly.

• File: proto/kyve/delegation/v1beta1/tx.proto
  • Line 5: import "cosmos/msg/v1/msg.proto";

🧰 Tools

🪛 Buf (1.47.2)

5-5: import "cosmos/msg/v1/msg.proto": file does not exist

(COMPILE)

x/stakers/types/codec.go (2)

3-10: Correctly added delegation types import

The import for the delegation module's v1beta1 types has been properly added to register the message handler.

---

27-27: Properly registered delegation MsgUpdateParams type

The delegation module's MsgUpdateParams message is correctly registered as an implementation of the sdk.Msg interface, following the same pattern as the existing registrations. This ensures the message can be properly decoded and routed in the Cosmos SDK framework.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.