Open
Conversation
KaddaOK
reviewed
Apr 13, 2024
Owner
KaddaOK
left a comment
KaddaOK
left a comment
There was a problem hiding this comment.
Sorry to leave this hanging for so long! I was not, apparently, actually getting any email from this account so I had no idea these were even here 😬
I have a delete line relay command in my unpushed changes from March 10, that we'll have to use instead of this because it has a bunch of stuff in it related to the keyboard functionality.
I'm also not sure I like having a delete button on every row as it's not something I suspect people will do very often. (Though it is weird that I've put it on the word context menu though too, so I'm going to contemplate it.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a button to delete the selected line on the EditLinesView