cleanup: remove minio defaults from broker, pass through operator env vars#119
Merged
novatechflow merged 1 commit intoKafScale:mainfrom Feb 28, 2026
Merged
Conversation
klaudworks
force-pushed
the
fix/remove-minio-defaults
branch
from
b964874 to
22b8dd2
Compare
klaudworks
changed the title
Collaborator
|
Good catch - that's from the first tests we did! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The broker had hardcoded minio defaults (bucket
kafscale, endpointhttp://127.0.0.1:9000, credentialsminioadmin:minioadmin). When S3 env vars were empty or missing, it silently fell back to these, even in real deployments.This caused a problem when deploying to AWS: setting region and bucket but not endpoint (correct for real S3) still resulted in the endpoint defaulting to
http://127.0.0.1:9000.The better default is AWS, the SDK can infer the endpoint from the region. A custom self-hosted endpoint can never be inferred, so that's what you should have to opt into explicitly, that's what people are used to from tools relying on the AWS SDK.
The minio/minio repo is now archived. All other code in this repo (Makefile, e2e tests, demo scripts) already passes S3 config explicitly, nothing depended on these minio broker defaults that can be explicitly set if needed.
This also passes through a few env vars that the operator wasn't forwarding to broker and etcd containers.