fix: move produce tagged fields inside partition loop#127
Open
klaudworks wants to merge 1 commit intoKafScale:mainfrom
Open
fix: move produce tagged fields inside partition loop#127klaudworks wants to merge 1 commit intoKafScale:mainfrom
klaudworks wants to merge 1 commit intoKafScale:mainfrom
Conversation
Collaborator
|
@klaudworks - same here |
ParseRequest and EncodeProduceRequest both placed the partition-level tagged fields call outside the inner partition loop. With multiple partitions per topic, the parser consumed only one tagged-field block instead of one per partition, corrupting subsequent partition reads. The encoder had a matching bug with a misleading comment claiming the deviation was intentional. Move SkipTaggedFields/WriteTaggedFields inside the for-partition loop in both functions. Add multi-partition round-trip and franz-go cross- compatibility tests that exercise the previously broken path.
klaudworks
force-pushed
the
fix/produce-tagged-fields
branch
from
9d0da7b to
076ad62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge #126 first, this pr is stacked on top. Closes #124.
Summary
outside the inner partition loop — ran once per topic instead of once per
partition. Multi-partition produces would generate/parse invalid wire format
for flexible versions (v9+).
produce v9 requests in both directions.