Skip to content

Conversation

@stevemessick
Copy link
Contributor

@stevemessick stevemessick commented Jan 26, 2026

In version 1.7.4.5 there were two definitions of this method. Someone (probably me) cleaned that up but deleted the second version, whereas the first was the one that was not being used.

Fixes #900

@stevemessick stevemessick requested a review from rosbo January 26, 2026 23:51
@@ -4993,7 +4993,7 @@ def split_dataset_string(self, dataset):
def validate_model_string(self, model: str) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "model string" is only {owner}/{model-slug}. The model instance string is {owner}/{model-slug}/{framework}/{variation-slug}/{version-number}. The validate_model_instance_string function should be used for the later. We should not update validate_model_string.

Your issue is that sometimes, the wrong one is called.

There are 2 calls to validate_model_string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

model_sources validation rejects documented format in v1.8.3

2 participants