Skip to content

[Poker] Add special case styles for Ties and All-ins #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2025
Merged

[Poker] Add special case styles for Ties and All-ins #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f528701
clean up + add special case styles for tie and all-in
chris-dmello Nov 12, 2025
90429f7
lint
chris-dmello Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 31 additions & 8 deletions ...nvs/open_spiel_env/games/repeated_poker/visualizer/default/src/repeated_poker_renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,9 +693,16 @@ export function renderer(options: RendererOptions): void {
? bestFiveCardHands[winnerIndex].match(/.{1,2}/g) || ([] as string[])
: ([] as string[]);

// Check for split pot
let isSplitPot = false;
// If both players are winners, then it's a split pot
if (stepType === 'final' && players.every((p) => (p as RepeatedPokerStepPlayer).isWinner)) {
isSplitPot = true;
}

// Add actual cards
for (let i = 0; i < numCards; i++) {
const shouldHighlight = winnerBestHand.includes(communityCardsArray[i]);
const shouldHighlight = !isSplitPot && winnerBestHand.includes(communityCardsArray[i]);
elements.communityCardsContainer.appendChild(createCardElement(communityCardsArray[i], false, shouldHighlight));
}

Expand All @@ -713,18 +720,23 @@ export function renderer(options: RendererOptions): void {
// Casting 'basePlayerData' to 'RepeatedPokerStepPlayer' to access properties.
const playerData = basePlayerData as RepeatedPokerStepPlayer;

const isWinner = playerData.actionDisplayText !== 'SPLIT POT' && playerData.isWinner;
const isSplitPot = playerData.actionDisplayText === 'SPLIT POT';
const isAllIn = playerData.actionDisplayText === 'ALL-IN';
const isTurn = playerData.isTurn;

const playerNameElement = elements.playerNames[index];
if (playerNameElement) {
playerNameElement.textContent = playerData.name;

if (playerData.isTurn) {
if (isTurn) {
playerNameElement.classList.add('current-turn');
} else {
playerNameElement.classList.remove('current-turn');
}

// Add winner class if player won
if (playerData.isWinner) {
if (isWinner) {
playerNameElement.classList.add('winner');
} else {
playerNameElement.classList.remove('winner');
Expand Down Expand Up @@ -758,8 +770,8 @@ export function renderer(options: RendererOptions): void {
bestFiveCardHands && bestFiveCardHands[index]
? bestFiveCardHands[index].match(/.{1,2}/g) || ([] as string[])
: ([] as string[]);
const shouldHighlightWinningHand = playerData.isWinner && showCards && isShowdown && bestHandArray.length > 0;

const shouldHighlightWinningHand = isWinner && showCards && isShowdown && bestHandArray.length > 0;
(playerCardsArray || [null, null]).forEach((cardStr) => {
const shouldHighlight = shouldHighlightWinningHand && cardStr && bestHandArray.includes(cardStr);
playerCardsContainer.appendChild(
Expand All @@ -777,14 +789,17 @@ export function renderer(options: RendererOptions): void {
const playerInfoArea = elements.playerInfoAreas[index];
if (playerInfoArea) {
// Highlight active player's pod
if (playerData.isTurn) {
if (isTurn) {
playerInfoArea.classList.add('active-player');
} else {
playerInfoArea.classList.remove('active-player');
}
if (isSplitPot) {
playerInfoArea.classList.add('split-pot');
}

// Highlight winner's pod
if (playerData.isWinner) {
if (isWinner) {
playerInfoArea.classList.add('winner-player');
} else {
playerInfoArea.classList.remove('winner-player');
Expand All @@ -797,16 +812,24 @@ export function renderer(options: RendererOptions): void {

const betDisplay = playerInfoArea.querySelector('.bet-display') as HTMLElement;
if (betDisplay) {
if (playerData.isWinner) {
if (isWinner) {
betDisplay.classList.add('winner-player');
} else if (isSplitPot) {
betDisplay.classList.add('split-pot');
} else {
if (isTurn) {
betDisplay.classList.add('active-player');
}
if (isAllIn) {
betDisplay.classList.add('all-in');
}
}
if (playerData.currentBet > 0) {
if (playerData.actionDisplayText) {
betDisplay.textContent = playerData.actionDisplayText;
} else {
betDisplay.textContent = '';
}
betDisplay.style.display = 'block';
}
}

Expand Down
22 changes: 21 additions & 1 deletion ...le_environments/envs/open_spiel_env/games/repeated_poker/visualizer/default/src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,10 @@
border-color: #ffeb70;
}

.player-info-area.split-pot {
border-color: #FF5C19;
}

.player-container-0 .player-info-area {
flex-direction: column-reverse;
}
Expand Down Expand Up @@ -433,20 +437,36 @@
padding: 10px;
border-radius: 30px;
background-color: #ffffff;
opacity: 0.7;
color: black;
font-family: "Inter", sans-serif;
font-size: 20px;
font-weight: 600;
text-align: center;
height: 20pxrem;
height: 20px;
line-height: 20px;
width: 240px;
min-height: 20px;
box-shadow: 0 2px 8px rgba(0, 0, 0, 0.3);
}

.bet-display.active-player {
opacity: 1;
}

.bet-display.winner-player {
background-color: #ffeb70;
opacity: 1;
}

.bet-display.split-pot {
opacity: 1;
background-color: #FF5C19;
}

.bet-display.all-in {
color: white;
background-color: #B3261E;
}

.blind-indicator {
Expand Down