Skip to content

Conversation

@Simplyauf
Copy link
Contributor

πŸ“ Pull Request Title

πŸ› οΈ Issue

  • Closes #add-your-issue-ID

πŸ“– Description

Please provide a general description of your changes. Include any relevant background information or context that may help reviewers understand the purpose of this PR.

πŸ–ΌοΈ Screenshots (if applicable)

  • Include any relevant screenshots or examples of the changes made. This helps reviewers visualize the updates

πŸ“ Additional Notes

  • Any additional context, questions, or considerations for the reviewers:

Copy link
Contributor

@coxmars coxmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Simplyauf The current code has significant limitations as it only returns static values.

  1. Implement helper functions for string manipulation, you can see our string lib in case we have some useful functions:

    • A function to convert felt252 to a collection (array) of characters
    • Functions to search for subsequences within a string
    • Functions to extract substrings
  2. Revise the parsing approach:

    • Analyze the URL to identify standard delimiters (://, /, ?, #)
    • Implement logic that actually processes the input and extracts each component
    • Handle cases where some components might be missing
  3. Include unit tests with different URL formats to verify that each function correctly extracts its component

The current code is a basic skeleton, but it needs an implementation that actually processes the provided input rather than returning hardcoded values.

@Simplyauf
Copy link
Contributor Author

@Simplyauf The current code has significant limitations as it only returns static values.

  1. Implement helper functions for string manipulation, you can see our string lib in case we have some useful functions:

    • A function to convert felt252 to a collection (array) of characters
    • Functions to search for subsequences within a string
    • Functions to extract substrings
  2. Revise the parsing approach:

    • Analyze the URL to identify standard delimiters (://, /, ?, #)
    • Implement logic that actually processes the input and extracts each component
    • Handle cases where some components might be missing
  3. Include unit tests with different URL formats to verify that each function correctly extracts its component

The current code is a basic skeleton, but it needs an implementation that actually processes the provided input rather than returning hardcoded values.

is it better now kindly check

Copy link
Contributor

@coxmars coxmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Simplyauf please apply those changes and we can merge

@Simplyauf
Copy link
Contributor Author

added

@coxmars coxmars merged commit 4cb40b8 into Kaizenode:main Apr 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants