-
Notifications
You must be signed in to change notification settings - Fork 75
feat added url parser #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Simplyauf The current code has significant limitations as it only returns static values.
-
Implement helper functions for string manipulation, you can see our string lib in case we have some useful functions:
- A function to convert felt252 to a collection (array) of characters
- Functions to search for subsequences within a string
- Functions to extract substrings
-
Revise the parsing approach:
- Analyze the URL to identify standard delimiters (://, /, ?, #)
- Implement logic that actually processes the input and extracts each component
- Handle cases where some components might be missing
-
Include unit tests with different URL formats to verify that each function correctly extracts its component
The current code is a basic skeleton, but it needs an implementation that actually processes the provided input rather than returning hardcoded values.
is it better now kindly check |
coxmars
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Simplyauf please apply those changes and we can merge
|
added |
π Pull Request Title
π οΈ Issue
π Description
Please provide a general description of your changes. Include any relevant background information or context that may help reviewers understand the purpose of this PR.
πΌοΈ Screenshots (if applicable)
π Additional Notes