fix(form-elements): add element internals mock stencil unit test#642
Open
QuintonJason wants to merge 1 commit intomainfrom
Open
fix(form-elements): add element internals mock stencil unit test#642QuintonJason wants to merge 1 commit intomainfrom
QuintonJason wants to merge 1 commit intomainfrom
Conversation
✅ Deploy Preview for pine-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
ElementInternalsmock to Stencil unit tests for form-associated components (input/textarea/select/checkbox/switch/combobox).setFormValueaccess warning as a test error.Motivation and Context
CI was failing on unit tests due to
ElementInternals.setFormValuebeing unimplemented in Stencil’s mock DOM. MockingattachInternalsin unit tests avoids console errors while keeping production code unchanged.Dependencies
Fixes #(issue)
Type of change
How Has This Been Tested?
Test Configuration:
cd libs/core && CI=1 npm test -- --ciChecklist: