Skip to content

fix(pds-dropdown-menu-item): add reflect option to target and external props #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuintonJason merged 3 commits into from
Feb 2, 2026
Merged

fix(pds-dropdown-menu-item): add reflect option to target and external props #656

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2f7cb1
fix(dropdown-menu-item): update prop reflect
QuintonJason Jan 30, 2026
5b8a99c
chore(release): release 3.15.2-dev.0
kajabi-bot Jan 30, 2026
77f873d
chore: resolve versions
QuintonJason Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libs/core/src/components/pds-dropdown-menu/pds-dropdown-menu-item/pds-dropdown-menu-item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,15 @@ export class PdsDropdownMenuItem implements BasePdsProps {
* This is a simpler alternative to using `target="_blank"` for the common case.
* @defaultValue false
*/
@Prop() external: boolean = false;
@Prop({ reflect: true }) external: boolean = false;

/**
* Specifies where to open the linked document when href is provided.
* Takes precedence over the `external` prop if both are set.
* Only applies when href is set.
* @defaultValue undefined
*/
@Prop() target?: '_blank' | '_self' | '_parent' | '_top';
@Prop({ reflect: true }) target?: '_blank' | '_self' | '_parent' | '_top';

/**
* Emitted when the dropdown-item is clicked.
Expand Down
Loading