fix(pds-dropdown-menu-item): add reflect option to target and external props#656
Merged
QuintonJason merged 3 commits intomainfrom Feb 2, 2026
Merged
fix(pds-dropdown-menu-item): add reflect option to target and external props#656QuintonJason merged 3 commits intomainfrom
QuintonJason merged 3 commits intomainfrom
Conversation
✅ Deploy Preview for pine-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pixelflips
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the
targetandexternalprops onpds-dropdown-menu-itemnot working when set via HTML attributes.The
targetandexternalprops were added in v3.15.0 but weren't being reflected from HTML attributes to component properties. This prevented them from being passed to the nestedpds-linkcomponent, making it impossible for links in dropdown menus to open in new tabs.Root Cause
Stencil requires the
reflect: trueoption on@Prop()decorators to sync HTML attributes with component properties. Without this option, setting an attribute liketarget="_blank"would add the HTML attribute but not update the component property.Solution
Added
reflect: trueto both prop decorators in pds-dropdown-menu-item.tsx to ensure proper attribute-to-property synchronization.Fixes DSS-116
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: