fix(pds-multiselect): add csrfHeaderName prop#657
Merged
QuintonJason merged 5 commits intomainfrom Feb 3, 2026
Merged
Conversation
✅ Deploy Preview for pine-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This reverts commit 93ded5e.
pixelflips
approved these changes
Feb 3, 2026
Member
pixelflips
left a comment
There was a problem hiding this comment.
Seems fine to me.
Maybe run coderabbit just for an extra check.
Member
|
Also some weird labels on the PR, but not sure if that effects anything or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The component documentation showed a
csrfHeaderNameprop, but it wasn't actually implemented. The CSRF header was hardcoded to'X-CSRF-Token'in both async fetch and create operations, preventing users from customizing it for frameworks that use different conventions (e.g., Django usesX-CSRFToken, Express may useX-XSRF-Token).Solution
csrfHeaderNameprop with default value'X-CSRF-Token'fetchOptions()method to use configurable header namecreateOption()method to use configurable header nameFixes DSS-125
Type of change
Please delete options that are not relevant.
If your type of change is not present, add that option.
How Has This Been Tested?
Please describe the tests you've added and run to verify your changes.
Provide instructions so that we can reproduce.
Please also list any relevant details for your test configuration.
Test Configuration:
Checklist:
If not applicable, leave options unchecked.