fix(pds-dropdown-menu-item): add reflect to prop#659
Draft
QuintonJason wants to merge 1 commit intomainfrom
Draft
fix(pds-dropdown-menu-item): add reflect to prop#659QuintonJason wants to merge 1 commit intomainfrom
QuintonJason wants to merge 1 commit intomainfrom
Conversation
✅ Deploy Preview for pine-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
reflect: trueto thedisabledprop onpds-dropdown-menu-itemto ensure the attribute is properly observed when set via server-rendered HTMLProblem
When using
pds-dropdown-menu-itemwith thedisabledattribute set in server-rendered HTML (e.g., from Rails templates), the component wasn't properly recognizing the disabled state. Theis-disabledclass wasn't being applied, and the visual disabled styling (opacity, cursor) wasn't rendering.Solution
Added
{ reflect: true }to thedisabledprop decorator. This ensures:is-disabledclass gets applied correctly, enabling the disabled stylingFixes DSS-128
Type of change
How Has This Been Tested?
Please describe the tests you've added and run to verify your changes.
Provide instructions so that we can reproduce.
Please also list any relevant details for your test configuration.
Test Configuration:
Checklist:
If not applicable, leave options unchecked.