Added the ability to set heater_fan speed #729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now heater_fan accepts SET_FAN_SPEED, while still respecting the minimum speed dictated by the heater being on (or off) The heater being on or off automatically sets the minimum speed the fans needs to respect, while manual requests can only set the speed higher than that, or request a lower speed that will be set only when the heater turns off and the temp is below the one in the config.
dalegaard
requested changes
Oct 15, 2025
| The following command is available when a | ||
| [fan_generic config section](Config_Reference.md#fan_generic) is | ||
| enabled. | ||
| [fan_generic](Config_Reference.md#fan_generic) |
Contributor
There was a problem hiding this comment.
This probably needs to be reflowed?
| current_temp, target_temp = heater.get_temp(eventtime) | ||
| if target_temp or current_temp > self.heater_temp: | ||
| speed = self.fan_speed | ||
| if (target_temp or current_temp > self.heater_temp) and self.enabled_fan_speed > speed: |
Contributor
There was a problem hiding this comment.
The logic here is a bit hard to follow, could we split it over multiple statements or something? I'm having a hard time understanding the interaction between last_gcode_speed and enabled_fan_speed as the code currently stands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now heater_fan accepts SET_FAN_SPEED, while still respecting the minimum speed dictated by the heater being on (or off)
The heater being on or off automatically sets the minimum speed the fans needs to respect, while manual requests can only set the speed higher than that, or request a lower speed that will be set only when the heater turns off and the temp is below the one in the config.
Checklist
I don't know if I have to add it to the readme myself, and I don't know that the "ci" is, but there are no conflicts