This is an open PR with the current fix and enhancement to Minemap, this is just to keep track of them#6
Open
hube12 wants to merge 122 commits intoKaptainWutax:masterfrom
Open
This is an open PR with the current fix and enhancement to Minemap, this is just to keep track of them#6hube12 wants to merge 122 commits intoKaptainWutax:masterfrom
hube12 wants to merge 122 commits intoKaptainWutax:masterfrom
Conversation
- fix salt dialog not saving change when not going out of a dialog (pressing immediately continue) - fix settings not getting the correct height (not having the close button accessible) - fix coordinates not showing up when settings enabled - fix size of icons fixed box making village icon squashed (now dynamic to the size of the icon but clamped to 20
- Under 600 px the settings are hidden because they cover more than half the screen (plus add some flickering issue due to GridBadLayout)
State management to its finest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.