Skip to content

Fix #249: Login and Get Started Buttons Visibility Issue on Mobile #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mandeep6207 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #249: Login and Get Started Buttons Visibility Issue on Mobile #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions src/components/Navbar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1546,13 +1546,18 @@
display: none;
}

/* On small screens the desktop auth controls should be hidden
and mobile menu auth buttons used instead. Don't hide the
button classes globally because mobile menu re-uses them. */
.desktop-auth {
display: flex !important;
display: none !important;
}

.navbar-btn-login,
.navbar-btn-signup {
display: none;

/* Ensure auth buttons inside the mobile menu are visible */
.mobile-menu .mobile-auth .navbar-btn,
.mobile-menu .mobile-auth .navbar-btn-login,
.mobile-menu .mobile-auth .navbar-btn-signup {
display: block;
}

.navbar-logo {
Expand Down Expand Up @@ -1620,13 +1625,17 @@
display: none;
}

/* On tablet narrow view hide the desktop auth controls so the
mobile toggle/menu provides the auth actions. Mobile auth
buttons inside the menu are handled separately. */
.desktop-auth {
display: flex !important;
display: none !important;
}

.navbar-btn-login,
.navbar-btn-signup {
display: none;

.mobile-menu .mobile-auth .navbar-btn,
.mobile-menu .mobile-auth .navbar-btn-login,
.mobile-menu .mobile-auth .navbar-btn-signup {
display: block;
}

.navbar-logo {
Expand Down
83 changes: 29 additions & 54 deletions src/components/Navbar.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ function Navbar() {
}, []);

useEffect(() => {
const handleClickOutside = (e) => {
if (openDropdown && !e.target.closest(".dropdown-container")) {
const handleClickOutside = (event) => {
if (openDropdown && !event.target.closest(".dropdown-container")) {
setOpenDropdown(null);
}
if (isProfileOpen && !event.target.closest('.profile-menu-container')) {
Expand All @@ -78,11 +78,11 @@ function Navbar() {
};

document.addEventListener("click", handleClickOutside);
document.addEventListener("keydown", handleEscape);
document.addEventListener("keydown", handleEscapeKey);

return () => {
document.removeEventListener("click", handleClickOutside);
document.removeEventListener("keydown", handleEscape);
document.removeEventListener("keydown", handleEscapeKey);
};
}, [openDropdown, isProfileOpen]);

Expand Down Expand Up @@ -115,6 +115,7 @@ function Navbar() {

return (
<nav
data-theme={theme}
className={`navbar ${scrolled ? "scrolled" : ""} ${
isMobileMenuOpen ? "has-mobile-menu" : ""
} ${isDashboardPage ? "is-dashboard" : ""}`}
Expand All @@ -128,57 +129,24 @@ function Navbar() {

{/* Desktop Menu */}
{!isDashboardPage && (
<ul className="navbar-menu">
{(currentUser ? authenticatedNavLinks : navLinks).map((link) => (
<li
key={link.label}
className="navbar-item"
onMouseEnter={() => link.dropdown && handleDropdownEnter(link.label)}
onMouseLeave={handleDropdownLeave}
>
{link.dropdown ? (
<>
<span
className="navbar-link dropdown-trigger"
onClick={() => handleDropdownClick(link.label)}
role="button"
aria-expanded={openDropdown === link.label}
aria-haspopup="true"
tabIndex={0}
onKeyDown={(e) => {
if (e.key === 'Enter' || e.key === ' ') {
e.preventDefault();
handleDropdownClick(link.label);
}
}}
<ul className="navbar-menu">
{linksToRender.map((link) => (
<li
key={link.label}
className="navbar-item"
onMouseEnter={() => link.dropdown && handleDropdownEnter(link.label)}
onMouseLeave={handleDropdownLeave}
>
{link.label}
</span>

<ul
className={`dropdown-menu ${openDropdown === link.label ? 'show' : ''}`}
role="menu"
aria-label={`${link.label} submenu`}
>
{!link.dropdown ? (
<Link
to={link.to}
className={`navbar-link ${
location.pathname === link.to ? "active" : ""
}`}
onClick={closeMobileMenu}
>
{link.label}
</Link>
) : (
{link.dropdown ? (
<>
<span
<button
type="button"
className="navbar-link dropdown-trigger"
onClick={() => handleDropdownClick(link.label)}
role="button"
tabIndex={0}
aria-haspopup="true"
aria-expanded={openDropdown === link.label}
onClick={() => handleDropdownClick(link.label)}
aria-haspopup="true"
tabIndex={0}
onKeyDown={(e) => {
if (e.key === "Enter" || e.key === " ") {
e.preventDefault();
Expand All @@ -187,13 +155,12 @@ function Navbar() {
}}
>
{link.label}
</span>
</button>

<ul
className={`dropdown-menu ${
openDropdown === link.label ? "show" : ""
}`}
className={`dropdown-menu ${openDropdown === link.label ? "show" : ""}`}
role="menu"
aria-label={`${link.label} submenu`}
>
{link.dropdown.map((item) => (
<li key={item.to} role="none">
Expand All @@ -209,6 +176,14 @@ function Navbar() {
))}
</ul>
</>
) : (
<Link
to={link.to}
className={`navbar-link ${location.pathname === link.to ? "active" : ""}`}
onClick={closeMobileMenu}
>
{link.label}
</Link>
)}
</li>
))}
Expand Down