Skip to content

Conversation

@NarxPal
Copy link

@NarxPal NarxPal commented Nov 10, 2025

Description

Added rotation support for text-overlay layer.

Type of Change

  • New feature

Testing

  • Tested manually

Screenshots

stage-1762792171627

Checklist

  • Self-review
  • No warnings
  • Code follows style

@gemini-code-assist
Copy link

Important

Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services.

@vercel
Copy link

vercel bot commented Nov 10, 2025

@NarxPal is attempting to deploy a commit to the Kartik Labhshetwar's projects Team on Vercel.

A member of the Team first needs to authorize it.

@KartikLabhshetwar
Copy link
Owner

@NarxPal please fix the merge conflicts

@NarxPal
Copy link
Author

NarxPal commented Nov 19, 2025

text rotation isn't happening with the slider after recent conflict merge, will be reviewing it and pushing back with changes

@NarxPal
Copy link
Author

NarxPal commented Nov 20, 2025

@KartikLabhshetwar, all merge conflicts have been resolved up to the latest commit hash -9ca81dfd245879b639fa722c3e2b7531f3d7cfcf .

changes can be seen in file text-overlay-controls.tsx and textOverlayLayer.tsx

@vercel
Copy link

vercel bot commented Nov 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
stage Ready Ready Preview Comment Nov 20, 2025 1:43pm

@KartikLabhshetwar
Copy link
Owner

@NarxPal please share a video of what exactly you have done here? because i think text rotation is already there?

@KartikLabhshetwar
Copy link
Owner

see this

516884413-2a905337-c83d-4327-af21-ed782908fdc2.mov

@NarxPal
Copy link
Author

NarxPal commented Nov 20, 2025

Screencast.from.2025-11-20.19-32-57.webm

@KartikLabhshetwar
currently text-overlay rotation only happens through konva's transformer handle and not through the slider , while stickers uses both slider and handle for rotation. so added slider support for text as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants