-
Notifications
You must be signed in to change notification settings - Fork 3
[PR] Fix: issue #57, add support for "Undecided" match results in outcome processing #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Let's see what copilot says! 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for handling "Undecided" match results in the SC2 dataset processing pipeline by updating outcome processing functions to recognize and skip replays with undecided results.
- Added "Undecided": -1 mapping to result dictionaries across transform functions
- Implemented early return logic to skip processing when "Undecided" results are detected
- Updated three transform functions to handle the new result type consistently
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
File | Description |
---|---|
src/sc2_datasets/transforms/utils.py | Added "Undecided" result mapping and early return logic in outcome processing |
src/sc2_datasets/transforms/pytorch/economy_vs_outcome.py | Added "Undecided" handling to economy statistics transformation |
src/sc2_datasets/transforms/mmr_vs_result.py | Added "Undecided" handling to MMR vs result transformation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there needs to be a little more thought put into this one. I believe my comments may be helpful ;)
Another thing that we have discussed is maybe having a validator that checks for any undecided games if someone would like to exclude these from modeling.
Check out if you are able to fix the CI. The automatic formatting should be a part of the development environment. Let me know if that works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This pull request improves the robustness of several data transformation functions by handling edge cases where a StarCraft II replay result is "Undecided", "Draw", or "Tie". Now, these cases are explicitly checked and skipped, preventing ambiguous or invalid labels from being processed in downstream tasks. Enhanced handling of ambiguous game results:
|
No description provided.