Skip to content

Conversation

scmisa
Copy link
Contributor

@scmisa scmisa commented Sep 9, 2025

No description provided.

@scmisa scmisa changed the title FIX: issue #57, add support for "Undecided" match results in outcome processing [PR] Fix: issue #57, add support for "Undecided" match results in outcome processing Sep 9, 2025
@Kaszanas
Copy link
Owner

Kaszanas commented Sep 9, 2025

Let's see what copilot says! 🤔

@Kaszanas Kaszanas requested a review from Copilot September 9, 2025 17:50
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for handling "Undecided" match results in the SC2 dataset processing pipeline by updating outcome processing functions to recognize and skip replays with undecided results.

  • Added "Undecided": -1 mapping to result dictionaries across transform functions
  • Implemented early return logic to skip processing when "Undecided" results are detected
  • Updated three transform functions to handle the new result type consistently

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
src/sc2_datasets/transforms/utils.py Added "Undecided" result mapping and early return logic in outcome processing
src/sc2_datasets/transforms/pytorch/economy_vs_outcome.py Added "Undecided" handling to economy statistics transformation
src/sc2_datasets/transforms/mmr_vs_result.py Added "Undecided" handling to MMR vs result transformation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

scmisa and others added 2 commits September 9, 2025 22:38
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Owner

@Kaszanas Kaszanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there needs to be a little more thought put into this one. I believe my comments may be helpful ;)

Another thing that we have discussed is maybe having a validator that checks for any undecided games if someone would like to exclude these from modeling.

Check out if you are able to fix the CI. The automatic formatting should be a part of the development environment. Let me know if that works.

@scmisa scmisa mentioned this pull request Sep 24, 2025
@scmisa scmisa requested a review from Copilot September 24, 2025 15:18
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@scmisa
Copy link
Contributor Author

scmisa commented Sep 25, 2025

This pull request improves the robustness of several data transformation functions by handling edge cases where a StarCraft II replay result is "Undecided", "Draw", or "Tie". Now, these cases are explicitly checked and skipped, preventing ambiguous or invalid labels from being processed in downstream tasks.

Enhanced handling of ambiguous game results:

  • Updated result_dict in mmr_vs_result.py, economy_vs_outcome.py, and utils.py to include mappings for "Undecided", "Draw", and "Tie" results, assigning them a value of -1. [1] [2] [3]
  • Added logic to all three modules to check for these ambiguous results and return None (or skip processing) when encountered, ensuring such replays are excluded from further analysis. [1] [2] [3]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants