Allow symlinks to test cases with other output validator flags and…#276
Open
Tagl wants to merge 1 commit intoKattis:developfrom
Open
Allow symlinks to test cases with other output validator flags and…#276Tagl wants to merge 1 commit intoKattis:developfrom
Tagl wants to merge 1 commit intoKattis:developfrom
Conversation
…rn if output validators fails to compile.
| self.error(f"Symbolic link '{nicepath}' must have a corresponding link for answer file") | ||
| return False | ||
| if self.reuse_result_from is None: | ||
| if not nicepath.startswith('data'): |
Member
There was a problem hiding this comment.
Isn't the previous check more accurate?
Member
There was a problem hiding this comment.
Sorry for late reply, but:
- this covers e.g.
data2too nicepathis the path prior to symlink resolution
| if res.verdict != 'AC': | ||
| return res | ||
| else: | ||
| self.warning(f"Compilation failed for {val.name}: {compile_res[1]}") |
Member
There was a problem hiding this comment.
Won't this result in a lot of warning spam (one log line per submission per test case)? IIRC we already give an error in an earlier phase.
Contributor
Author
There was a problem hiding this comment.
I had an error and got no information before adding this. It was very confusing.
I will double check though.
Contributor
There was a problem hiding this comment.
I've fixed this in a less spammy way in #319 where if validators fail to compile (or the problem uses the default validator and we can't find it), we stop validation before running any submissions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
..warn if output validators fails to compile. Closes #244
Note this may be a breaking change for some problem based on discussion in issue.
However that problem is not being validated "correctly" since the output validator generally should behave differently with different arguments passed to it, rendering reuse impossible.