Skip to content
This repository was archived by the owner on Mar 29, 2019. It is now read-only.

Profile class getDetails#64

Open
Isigar wants to merge 2 commits intoKdyby:masterfrom
Isigar:master
Open

Profile class getDetails#64
Isigar wants to merge 2 commits intoKdyby:masterfrom
Isigar:master

Conversation

@Isigar
Copy link

@Isigar Isigar commented Jan 17, 2018

Profile class is nice but i need to get all the data or just get some quickly.
So i added one new method getDetail only.

Usage:

$this->getDetail(["name","birthday","gender","email"]);
- default value is "name"

@enumag
Copy link
Member

enumag commented Apr 12, 2018

I have no idea what this is about since I never used this library. What do you think @PavelJurasek?

@PavelJurasek
Copy link

I haven't used this class in my projects either.

Looking at the commit, I wouldn't really change the implementation of getDetails method as it would introduce a BC break.
Calling new method getDetail with different values wouldn't work either. The idea might be good, but the implementation is lacking robustness.. Not to mention the violation of coding style.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants