Conversation
added 22 commits
March 24, 2026 16:37
as well as ACK and REP.
mattkbrown
approved these changes
Mar 31, 2026
mattkbrown
left a comment
mattkbrown
left a comment
There was a problem hiding this comment.
The merging of the two message types into one makes sense. it will be interesting to see how this affects transfer times, but I don't think it will be noticeable.
|
Closing this PR as consensus is that they should remain separate. Kyle will take the message changes he likes and create a new PR for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request modifies the on-the-wire ordering of the multipart message components such that all requests, responses, and publications are using exactly the same structure. As part of this change, reconstruction of messages from multipart tuples is now handled in a single method rather than in multiple places in the code base.
The main change to highlight is the elimination of the special message.Broadcast class. This required some broadening of the base message.Message class; it was further broadened when message.from_parts() was established to provide a single point-of-entry to translate any multipart message back into a message.Message instance.
The Message._finalize() method shows the key change for the ordering, where the target/topic field is now first among multiparts in order for the PUB/SUB case to continue working as expected.