Fix multisig descriptor detection #6529
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Parsh
approved these changes
Jun 9, 2025
ben-kaufman
requested changes
Jun 10, 2025
Collaborator
ben-kaufman
left a comment
ben-kaufman
left a comment
There was a problem hiding this comment.
This would need to update the logic in general for the change to make sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
parseTextforVaultConfigdetects multisig descriptors when they containsortedmulti(Testing
npm test(fails: jest not found)npm run lint(fails: ESLint couldn't find config)https://chatgpt.com/codex/tasks/task_e_6846a701a0748323b41d1aa824ba33d3