Add Satochip hardware wallet support #6868
Conversation
…, import seed & reset seed
Better to reset seed from the import Satochip key options during new key import.
…tSatochipSeed old resetSatochipSeed screen: reset from settings using provided PIN new resetSatochipSeed screen: reset from Satochip key add, use pin from previous screen
The error arose from an incorrect parsing of the BIP32 path, that led to a wrong key derivation for Satochip, when using remote key signing.
The patch is:
+ let keypath = "";
+ if (signer.derivationPath.endsWith("/") || input.subPath.startsWith("/")){
+ keypath = signer.derivationPath + input.subPath;
+ } else {
+ keypath = signer.derivationPath + "/" + input.subPath;
+ }
+ console.log(`index signWithSatochip keypath: ${keypath}`);
Update Satochip branch with upstream changes
|
Thanks for the PR! I've tested and everything worked (mostly) well. Also on the first try for actually adding the card the app crashed, but I couldn't reproduce this after the first time. When I retried adding a few times after it worked well. Also on this screen make sure please to have the buttons at the bottom like in the rest of the app And also on the UI, I think it's a bit confusing to have 4 of the buttons for different actions in the setup screen, I'd recommend adding a settings or options button and move at least the check setup and reset seed there. Besides everything worked well. Import succeeded, initializw and reset of the card, change PIN, signing with all wallet types. So. overall very good integration! |
If no PIN is provided, display a more explicit error message to user stating that authenticity could not be verified without the PIN. Also remove unused/useless code in getScriptSpecificDetails().
|
Thanks for the detailed review! |
Replace the 4 setup options with a single "Setup options" button. Opens a Setup options modal for various Satochip configuration options.
|
I have refactored the Satochip setup screen to add the setup options in a modal window:
This should fix the last remaining issue for this PR. |
ben-kaufman
left a comment
ben-kaufman
left a comment
There was a problem hiding this comment.
Looks good!
Just a small comment, and also when clicking Import or reset in the setup options before entering the PIN nothing happens, it'd be better to show a toast to the user asking to enter the PIN
When clicking Import or reset in the setup options before entering the PIN, nothing happened. Now a toast is shown to the user asking to enter the PIN first.
ben-kaufman
left a comment
ben-kaufman
left a comment
There was a problem hiding this comment.
Looks good, thanks for making this!
cakesoft-vaibhav
merged commit 7060ea9
into
KeeperCommunity:sprint
3 participants
This is a pull request to add support for the Satochip hardware wallet.
The Satochip hardware wallet is based on a jacavard smartcard and is fully open-source.
The firmware uses a javacard applet that is loaded on the smartcard.
With native NFC (Near Field Communication) support, Satochip enables seamless interaction with mobile devices.
Satochip technical details
Advantages of Satochip
Here are the main advantages of the Satochip hardware wallet:
More info:
https://github.com/Toporin/ (Official repository)
https://x.com/satochip (X account)
https://t.me/Satochip (Telegram support)
https://satochip.io (Official website)