Change the way the FX Service Auto-Run works #163
Merged
+476
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the FX Service Auto-Run mechanism from an interval-based background process to a request-triggered approach, making it more suitable for serverless environments where background intervals don't work well.
Changes:
- Replaced interval-based queue processing with request-triggered processing
- Queue processing now occurs synchronously during HTTP request handling before responding
- Added mutex mechanism using
autoRunRunningflag to prevent concurrent queue processing
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/services/fx/server.ts | Removed interval-based auto-run, added request-triggered queue processing with mutex flag, processes queue for up to 15s before responding |
| src/services/fx/server.test.ts | Added comprehensive tests for concurrent request handling and multiple servers sharing a queue, removed debug console.log statement |
Srayman
approved these changes
Jan 23, 2026
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change alters the way FX AutoRun works by running the queue prior to responding to HTTP requests, which is better suited to Serverless environments.