Skip to content

Refactor [V12 feature container] #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kephson merged 7 commits into from
Oct 13, 2025
Merged

Refactor [V12 feature container] #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
81db3c0
[FEATURE][WIP] add support for EXT:container
DavidBruchmann Apr 10, 2025
d2cea86
[BUGFIX] fix raceCondition by replacing CSS-class for EventHandler / …
DavidBruchmann Apr 21, 2025
b350f25
[TASK] adjust JS-code style
DavidBruchmann Apr 21, 2025
f5c07ba
[Task] refactor paste-reference.js, fix #79
DavidBruchmann Sep 8, 2025
46224fa
[Task] remove useless imports in paste-reference.js
DavidBruchmann Sep 8, 2025
5835a71
[Task][v3] only log in the console if 'fieldName not defined in messa…
DavidBruchmann Sep 8, 2025
950c246
[Bugfix] instantiate JS-class if it's not done automatically, [Bugfix…
DavidBruchmann Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions Resources/Public/JavaScript/paste-reference-drag-drop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,9 @@ DragDrop.default = {

$(DragDrop.default.dropZoneIdentifier).not(DragDrop.default.ownDropZone).each(function () {
$(this).addClass(DragDrop.default.validDropZoneClass);
if (($(this).not(disabledDropZones).length
|| siblingsDropZones.length
) &&
$(this).parent().find('.icon-actions-add').length
if (
($(this).not(disabledDropZones).length || siblingsDropZones.length)
&& $(this).parent().find('.icon-actions-add').length
) {
$(this).addClass(DragDrop.default.validDropZoneClass);
} else {
Expand Down Expand Up @@ -173,6 +172,7 @@ DragDrop.default = {
*/
onDrop: function ($draggableElement, $droppableElement, evt, reference) {
const newColumn = DragDrop.default.getColumnPositionForElement($droppableElement) ?? 0;
const containerParent = DragDrop.default.getContainerParentForElement($droppableElement) ?? 0;

$droppableElement.removeClass(DragDrop.default.dropPossibleHoverClass);
const $pasteAction = typeof $draggableElement === 'number' || typeof $draggableElement === 'undefined';
Expand Down Expand Up @@ -261,6 +261,9 @@ DragDrop.default = {
if (evt === 'copyFromAnotherPage') {
parameters['CB'] = {setCopyMode: 1};
}
if (containerParent) {
parameters['cmd']['tt_content'][contentElementUid]['copy']['update']['tx_container_parent'] = containerParent;
}
// fire the request, and show a message if it has failed
// This is adding a copy from another page "to this [selected] place".
AjaxDataHandler.process(parameters).then(function (result) {
Expand Down Expand Up @@ -290,6 +293,9 @@ DragDrop.default = {
}
}
};
if (containerParent) {
parameters['cmd']['tt_content'][contentElementUid]['move']['update']['tx_container_parent'] = containerParent;
}
// fire the request, and show a message if it has failed
AjaxDataHandler.process(parameters).then(function (result) {
if (!result.hasErrors) {
Expand Down Expand Up @@ -323,6 +329,20 @@ DragDrop.default = {
} else {
return false;
}
},

/**
* returns the next "upper" container parent parameter inside the code
* @param $element
* @return int|boolean the containerParent
*/
getContainerParentForElement: function ($element) {
const $gridContainer = $element.closest('[data-tx-container-parent]');
if ($gridContainer.length && $gridContainer.data('txContainerParent') !== 'undefined') {
return $gridContainer.data('txContainerParent');
} else {
return false;
}
}
}

Expand Down
Loading