Doctool migration 58558 by bhillkeyfactor · Pull Request #10 · Keyfactor/kemp-orchestrator

bhillkeyfactor · 2025-10-27T16:04:41Z

No description provided.

…nd upgrade bootstrap workflow

… Phrase Style

Copilot

Pull Request Overview

This PR migrates the Kemp Load Balancer orchestrator to a new documentation and build tooling system. It updates the project to support .NET 6 and .NET 8, modernizes the integration manifest with detailed store type configuration, and significantly expands documentation with setup guides and test case details.

Adds comprehensive store type configuration to integration-manifest.json including properties, parameters, and capabilities
Creates new documentation structure with setup guides, API enablement instructions, and detailed behavior summaries
Updates project to multi-target .NET 6 and .NET 8 with upgraded dependencies

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
integration-manifest.json	Expanded with full store type definition including properties (ServerUsername, ServerPassword, ServerUseSsl) and operation support details
docsource/kemp.md	New placeholder documentation file with TODO sections for Overview, Requirements, and Certificate Store Configuration
docsource/content.md	New comprehensive documentation including API setup guide, orchestrator behavior summary, and detailed test case descriptions
README.md	Complete rewrite with modern formatting, detailed installation instructions, store type creation guide, and Kemp LoadMaster configuration steps
Kemp/Kemp.csproj	Updated to multi-target net6.0 and net8.0, upgraded RestSharp from 107.2.1 to 112.1.0, added implicit usings configuration
Kemp.sln	Updated Visual Studio version from 16 to 17
CHANGELOG.md	New file documenting v2.0.0 release with .NET 6/8 support and v1.0.0 initial release
.github/workflows/keyfactor-starter-workflow.yml	Removed old workflow file
.github/workflows/keyfactor-release-workflow.yml	Added new bootstrap workflow using Keyfactor actions v3

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-11T15:04:01Z

integration-manifest.json

+"UOFramework": "10.4",
+"keyfactor_platform_version": "10.4",
+"pam_support": true,
+"keyfactor_platform_version": "10.4",


Duplicate key keyfactor_platform_version found in the orchestrator configuration. Line 17 should be removed to ensure valid JSON.

Suggested change

"keyfactor_platform_version": "10.4",

Copilot · 2025-11-11T15:04:01Z

README.md

@@ -129,5 +432,10 @@ Case Number|Case Name|Case Description|Overwrite Flag|Alias Name|Expected Result
 11|Inventory SSL Certificates|SS: Certificate Will Be Inventoried|N/A|N/A|SSL Certificate Is Inventoried to Keyfactor|True|![](images/TC11Results.gif)


Copilot · 2025-11-11T15:04:02Z

docsource/content.md

+8|Replace Alias Intermediate Certificates|You cannot replace intermediate certificates|True|TC8b|Command Failed: Filename already exists|True|![](images/TC8Results.gif)
+9|Remove Intermediate Certificates|Intermediate Certificate Will Be Removed|N/A|TC8b|Intermediate Certificate Is Removed From Keyfactor and the LoadMaster|True|![](images/TC9Results.gif)
+10|Inventory Intermediate Certificates|Intermediate Certificate Will Be Inventoried|N/A|N/A|Intermediate Certificate Is Inventoried to Keyfactor|True|![](images/TC10Results.gif)
+11|Inventory SSL Certificates|SS: Certificate Will Be Inventoried|N/A|N/A|SSL Certificate Is Inventoried to Keyfactor|True|![](images/TC11Results.gif)


Copilot · 2025-11-11T15:04:02Z

README.md

+TODO Overview is a required section
+
+
+
+


TODO placeholder for Overview section should be resolved before merging. This section is marked as required and needs actual content.

Suggested change

TODO Overview is a required section

Copilot · 2025-11-11T15:04:02Z

README.md

+#### Kemp Requirements
+
+TODO Requirements is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info
+
+
+


TODO placeholder should be removed or replaced with actual content. If the Requirements section is not needed, the entire section should be deleted.

Suggested change

#### Kemp Requirements

TODO Requirements is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info

Copilot · 2025-11-11T15:04:03Z

README.md

+## Defining Certificate Stores
+
+
+TODO Certificate Store Configuration is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info


TODO placeholder should be removed or replaced with actual content. If the Certificate Store Configuration section is not needed, the entire section should be deleted.

Suggested change

TODO Certificate Store Configuration is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info

Copilot · 2025-11-11T15:04:03Z

docsource/kemp.md

@@ -0,0 +1,12 @@
+## Overview
+
+TODO Overview is a required section


TODO placeholder for Overview section should be resolved. This section is marked as required and needs actual content.

Suggested change

TODO Overview is a required section

This document provides an overview of the Kemp certificate store integration, detailing how Keyfactor interacts with Kemp LoadMaster appliances to manage SSL/TLS certificates. It covers the key features, supported operations, and configuration steps required to enable secure certificate lifecycle management within Kemp environments.

Copilot · 2025-11-11T15:04:03Z

docsource/kemp.md

+## Requirements
+
+TODO Requirements is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info
+


TODO placeholder should be removed or replaced with actual content. If the Requirements section is not needed, the entire section should be deleted.

Suggested change

## Requirements

TODO Requirements is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info

Copilot · 2025-11-11T15:04:04Z

docsource/kemp.md

+## Certificate Store Configuration
+
+TODO Certificate Store Configuration is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info
+


TODO placeholder should be removed or replaced with actual content. If the Certificate Store Configuration section is not needed, the entire section should be deleted.

Suggested change

## Certificate Store Configuration

TODO Certificate Store Configuration is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info

Copilot

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-11T16:56:05Z

README.md

+## Discovering Certificate Stores with the Discovery Job
+TODO Discovery is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info
+
+
+
+



This TODO placeholder should be replaced with actual discovery job documentation or removed since the integration-manifest.json indicates that Discovery is not supported ("supportsDiscovery": false). The section title is misleading if discovery is not a supported feature.

Suggested change

## Discovering Certificate Stores with the Discovery Job

TODO Discovery is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info

Copilot · 2025-11-11T16:56:05Z

Kemp/Kemp.csproj

    <PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
    <PackageReference Include="Portable.BouncyCastle" Version="1.9.0" />
-    <PackageReference Include="RestSharp" Version="107.2.1" />
+    <PackageReference Include="RestSharp" Version="112.1.0" />


The RestSharp package is being updated from version 107.2.1 to 112.1.0. This is a major version upgrade (from v107 to v112) that may introduce breaking changes. Ensure that all RestSharp API calls in the codebase are compatible with version 112.1.0, as major version updates often include breaking API changes.

Copilot · 2025-11-11T16:56:06Z

docsource/content.md

+## Overview
+
+TODO Overview is a required section
+
+## Requirements
+
+TODO Requirements is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info
+
+## Post Installation
+
+TODO Post Installation is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info
+
+## Discovery
+
+TODO Discovery is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info
+


The TODO placeholders in this file suggest this is a template that hasn't been customized for the Kemp orchestrator. Since comprehensive documentation already exists in docsource/kemp.md, consider either removing this file or properly implementing these sections with Kemp-specific content.

Suggested change

## Overview

TODO Overview is a required section

## Requirements

TODO Requirements is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info

## Post Installation

TODO Post Installation is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info

## Discovery

TODO Discovery is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info

Copilot · 2025-11-11T16:56:06Z

README.md

+## Overview

-This repository contains a Universal Orchestrator Capability which is a plugin to the Keyfactor Universal Orchestrator. Within the Keyfactor Platform, Orchestrators are used to manage “certificate stores” &mdash; collections of certificates and roots of trust that are found within and used by various applications.
+TODO Overview is a required section


Multiple TODO placeholders remain in the README that should be replaced with actual content. Lines 34, 52, 202, and 431 all contain TODO statements that need to be completed before this documentation is production-ready.

Copilot · 2025-11-11T16:56:06Z

README.md

+TODO Requirements is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info
+
+


This TODO placeholder should be replaced with actual requirements or removed if no additional requirements beyond those already documented are needed. The Confluence link reference suggests this needs completion.

Suggested change

TODO Requirements is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info

Copilot · 2025-11-11T16:56:06Z

README.md

+## Post Installation
+
+TODO Post Installation is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info
+
+


This TODO placeholder should be replaced with actual post-installation steps or removed if no post-installation configuration is needed. The Confluence link reference suggests this needs completion.

Suggested change

## Post Installation

TODO Post Installation is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info

m8rmclaren and others added 25 commits July 3, 2024 20:06

chore(docs): Translate doc structure for compatibility with doctool a…

6bf7542

…nd upgrade bootstrap workflow

chore(manifest): Re-create description fields in manifest to use Noun…

8dfdfd9

… Phrase Style

dual build and doc updates

7ad65e3

Update generated docs

c4d6fa5

Update keyfactor-release-workflow.yml

23e576c

Update integration-manifest.json

3115e05

Update generated docs

9048773

Update integration-manifest.json

5d84b7b

Update kemp.md

e8db52e

Update generated docs

ec02542

Update kemp.md

a289e88

Update generated docs

0db8783

Delete docsource/kemp.md

64f6f56

Update content.md

3cb7c6d

Update generated docs

8a4e1b6

Update content.md

1d9d150

Update generated docs

3d4b309

Update content.md

7514e2f

Update generated docs

89f30c0

Update README.md

f07a6ce

Update generated docs

cd2f45a

Update content.md

c6abc88

Update generated docs

6e37482

Create CHANGELOG.md

a3c838d

Update CHANGELOG.md

aad1ffd

bhillkeyfactor requested review from doebrowsk and spbsoluble October 27, 2025 20:12

bhillkeyfactor and others added 3 commits October 30, 2025 11:24

Update kemp.md

76e8734

Update kemp.md

830a5ac

Update generated docs

d9ef33e

spbsoluble requested a review from Copilot November 11, 2025 15:01

Copilot started reviewing on behalf of spbsoluble November 11, 2025 15:02 View session

Copilot finished reviewing on behalf of spbsoluble November 11, 2025 15:02

Copilot AI reviewed Nov 11, 2025

View reviewed changes

bhillkeyfactor and others added 7 commits November 11, 2025 11:10

Delete docsource/kemp.md

f856eda

Update integration-manifest.json

147c68f

Update generated docs

62719fa

Update content.md

dbce865

Update kemp.md

93aa0ce

Delete docsource/content.md

961d7a6

Update generated docs

ccb7ba2

spbsoluble requested a review from Copilot November 11, 2025 16:53

Copilot started reviewing on behalf of spbsoluble November 11, 2025 16:53 View session

Copilot finished reviewing on behalf of spbsoluble November 11, 2025 16:54

Copilot AI reviewed Nov 11, 2025

View reviewed changes

bhillkeyfactor and others added 3 commits November 11, 2025 13:18

Update kemp.md

8e1c128

Update content.md

ec70a29

Update generated docs

66537ca

bhillkeyfactor merged commit e47eda2 into release-2.0 Nov 11, 2025

		@@ -129,5 +432,10 @@ Case Number\|Case Name\|Case Description\|Overwrite Flag\|Alias Name\|Expected Result
		11\|Inventory SSL Certificates\|SS: Certificate Will Be Inventoried\|N/A\|N/A\|SSL Certificate Is Inventoried to Keyfactor\|True\|![](images/TC11Results.gif)

	11\|Inventory SSL Certificates\|SS: Certificate Will Be Inventoried\|N/A\|N/A\|SSL Certificate Is Inventoried to Keyfactor\|True\|![](images/TC11Results.gif)
	11\|Inventory SSL Certificates\|SSL Certificate Will Be Inventoried\|N/A\|N/A\|SSL Certificate Is Inventoried to Keyfactor\|True\|![](images/TC11Results.gif)

		#### Kemp Requirements

		TODO Requirements is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info

		## Defining Certificate Stores


		TODO Certificate Store Configuration is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info

		@@ -0,0 +1,12 @@
		## Overview

		TODO Overview is a required section

	TODO Overview is a required section
	This document provides an overview of the Kemp certificate store integration, detailing how Keyfactor interacts with Kemp LoadMaster appliances to manage SSL/TLS certificates. It covers the key features, supported operations, and configuration steps required to enable secure certificate lifecycle management within Kemp environments.

		## Requirements

		TODO Requirements is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info

		## Certificate Store Configuration

		TODO Certificate Store Configuration is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info

		## Discovering Certificate Stores with the Discovery Job
		TODO Discovery is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info

		## Post Installation

		TODO Post Installation is an optional section. If this section doesn't seem necessary on initial glance, please delete it. Refer to the docs on [Confluence](https://keyfactor.atlassian.net/wiki/x/SAAyHg) for more info

Conversation

bhillkeyfactor commented Oct 27, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants