avoids emitting duplicate import declarations in case of multiple type imports#283
avoids emitting duplicate import declarations in case of multiple type imports#283demedos wants to merge 1 commit intoKhan:masterfrom
Conversation
|
Hey @demedos, Thanks for the PR! Mind signing our Contributor License Agreement? When you've done so, go ahead and comment Once you've done that, could you also add a test case that verifies the change you've made? |
|
@kevinbarabash could you take a look at this? When someone contributes to a project, that implies that they comply with the license. There is no reason to collect separate signatures for that. |
Thank you, that is the exact reason I didn't update the pull request. |
|
Thanks for the feedback and for the contribution. Unfortunately, the implication of agreement is not sufficient for us and we need all contributors to sign the agreement so that it is explicit that the license agreement has been read and understood. We try to make the CLA process as smooth as possible but do need a CLA signed (as do many other open source initiatives). Thank you for taking a moment to do so. |
|
@demedos Are you interested in signing the CLA? If not, I can do this because I have already made PRs to this repository. |
Feel free to do so |
avoids emitting duplicate import declarations in case of multiple type imports
fixes #281