This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Convert $Diff<T, U> -> Omit<T, keyof U>#396
Open
seansfkelley wants to merge 1 commit intoKhan:masterfrom
Open
Conversation
This is a lossy conversion, since Flow requires that `U` is an object type and that `T` (1) has all the keys of `U` and (2) the corresponding values of `T` are assignable to those of `U`. A closer analogue would use `OmitStrict` instead of `Omit` (where `type OmitStrict<T, K extends keyof T> = Pick<T, Exclude<keyof T, K>>`) but using the standard `Omit` means we don't need to add potentially-conflicting definitions elsewhere to import here.
seansfkelley
force-pushed
the
diff-to-omit
branch
from
faad782 to
7511c48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a lossy conversion, since Flow requires that
Uis an object type and thatT(1) has all the keys ofUand (2) the corresponding values ofTare assignable to those ofU. A closer analogue would useOmitStrictinstead ofOmit(wheretype OmitStrict<T, K extends keyof T> = Pick<T, Exclude<keyof T, K>>) but using the standardOmitmeans we don't need to add potentially-conflicting definitions elsewhere to import here.