Updated FieldName validation logic #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x patterns. Valid/Invalid field names are still generated from a property tree, however the field names are stored as Regex patterns. Also addressed issue with validating field names that defined an array indexer in the path. Changed the SortingFields and Filters properties to be nullable to avoid MVC validation superseding Fluent Validation. This prevents the MVC "property is required" error when a request does have any of the properties present in the request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated FieldName validation logic to now match against expected Regex patterns. Valid/Invalid field names are still generated from a property tree, however the field names are stored as Regex patterns.
Also addressed issue with validating field names that defined an array indexer in the path.
Changed the SortingFields and Filters properties to be nullable to avoid MVC validation superseding Fluent Validation. This prevents the MVC "property is required" error when a request does have any of the properties present in the request.