Skip to content

Conversation

popescu-v
Copy link
Collaborator

@popescu-v popescu-v commented Oct 17, 2025

closes #465

TODO Before Asking for a Review

  • Rebase your branch to the latest version of dev (or main for release PRs)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

@popescu-v popescu-v self-assigned this Oct 17, 2025
@popescu-v popescu-v linked an issue Oct 17, 2025 that may be closed by this pull request
@popescu-v popescu-v force-pushed the 465-add-support-for-python-314 branch 2 times, most recently from 1294803 to b727b25 Compare October 17, 2025 16:58
@popescu-v popescu-v force-pushed the 465-add-support-for-python-314 branch from b25e5ee to 64a4b11 Compare October 17, 2025 17:21
Copy link
Member

@folmos-at-orange folmos-at-orange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also squash everything.

CHANGELOG.md Outdated
## Unreleased -

### Added
- (`general`) Support for Python 3.14.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general -> General (without backticks)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right, I'd fix this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Collaborator

@tramora tramora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@popescu-v
Copy link
Collaborator Author

popescu-v commented Oct 21, 2025

I'd also squash everything.

Not sure, because the "unpinning" of openssl is a side-effect which is potentially consequential on certain deployments (to validate by @tramora ?).
Hence, I would keep this change in a separate commit, whence have 2 commits.

…losed

Otherwise, keeping the pin is not harmless, as it breaks the dependency
graph when using Python 3.14.
@popescu-v popescu-v force-pushed the 465-add-support-for-python-314 branch from 64a4b11 to 0c0ba31 Compare October 21, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Python 3.14

3 participants