Skip to content

Add support for empty properties vector in commandNDRangeKernel#334

Merged
bashbaug merged 1 commit intoKhronosGroup:mainfrom
MohammadBadir:mohammadb/propertiesVector
Oct 1, 2025
Merged

Add support for empty properties vector in commandNDRangeKernel#334
bashbaug merged 1 commit intoKhronosGroup:mainfrom
MohammadBadir:mohammadb/propertiesVector

Conversation

@MohammadBadir
Copy link
Contributor

In the C API, we pass properties in a 0 terminated array, or we can pass nullptr if we don't want any properties.

In the C++ bindings, properties are passed in a vector reference. This forces us to pass a vector containing 0 if we don't want properties, causing boilerplate. My change allows passing an empty vector, which would pass nullptr to the C API.

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This is a bit different than the pattern used by other functions with vectors of properties, but I like this version better.

@bashbaug bashbaug merged commit 5da27ce into KhronosGroup:main Oct 1, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants