pass vectors by reference in getters#335
Merged
bashbaug merged 2 commits intoKhronosGroup:mainfrom Oct 1, 2025
Merged
Conversation
|
|
bashbaug
approved these changes
Oct 1, 2025
Contributor
bashbaug
left a comment
bashbaug
left a comment
There was a problem hiding this comment.
This is a very nice improvement - thank you!
It'd be nice to have some tests for these overloads at some point, though the existing testing is fairly sparse / nonexistent...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #331
I do not think, the
if(ptr)checks do anything that is not covered by thenullptrcheck already, but I kept them, because they were there.However, in my opinion, they should probably be removed, given, they return
CL_SUCCESSon failure.I only wrote overloads for the getters.
This pattern also appears on two other functions and seemingly on everything related to Events.
I did not want to introduce too much code at once.