Host allocation sharing via set final data - construction->destruction#502
Host allocation sharing via set final data - construction->destruction#502gmlueck merged 2 commits intoSYCL-2020/masterfrom
Conversation
|
The existing wording seems to reflect one very specific use case of |
|
Note that the paragraph you changed will be removed in #298 along with the entire section that contains it. Change #298 is currently pending agreement on the exact semantics of I'm not really opposed to the change you propose, but I think we need a bigger clarification to this part of the spec. |
keryell
left a comment
There was a problem hiding this comment.
Let's commit this anyway since even if it is to be replaced later, it is still an improvement today.
|
This PR needs one more reviewer. |
|
We could use one more reviewer here before today's WG meeting. |
AerialMantis
left a comment
There was a problem hiding this comment.
Good catch, looks good.
|
WG approved |
Host allocation sharing via set final data - construction->destruction
Host allocation sharing via set final data - construction->destruction (cherry picked from commit cd5768d)
Host allocation sharing via set final data - construction->destruction (cherry picked from commit cd5768d)
I'm not completely sure of this fix, but I think "destruction" fits better here since
set_final_datais called post-construction. Maybe better to say "valid at buffer destruction" instead of "after", but that matters less.