Skip to content

Clarifications to command interfaces section #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AerialMantis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clarifications to command interfaces section #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions source/iface/common-reference.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@ Each of the following SYCL runtime classes:
:ref:`command-accessor`, :ref:`buffer`, :ref:`context`, :ref:`device`,
:ref:`device_image`, :ref:`event`, :ref:`host_accessor`,
:ref:`host_sampled_image_accessor`, :ref:`host_unsampled_image_accessor`,
:ref:`kernel`, :ref:`kernel_id`, :ref:`sycl::kernel_bundle <iface-kernel-bundle>`,
:ref:`kernel`, :ref:`kernel_id`, :ref:`sycl::kernel_bundle`,
Copy link
Contributor

@gmlueck gmlueck Apr 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you say that this link is misleading? Before your change, the link went to the right place. Now, there is no link.

:ref:`local_accessor`, :ref:`platform`, :ref:`queue`, :ref:`sampled_image`,
:ref:`sampled_image_accessor`, :ref:`unsampled_image` and :ref:`unsampled_image_accessor`
:ref:`sampled_image_accessor`, :ref:`stream`, :ref:`unsampled_image`,
:ref:`unsampled_image_accessor`
must obey the following statements, where ``T`` is the runtime class type:

* ``T`` must be copy constructible and copy assignable in the host application
Expand Down