Clarifications to backends section#194
Open
AerialMantis wants to merge 1 commit intoKhronosGroup:mainfrom
Open
Clarifications to backends section#194AerialMantis wants to merge 1 commit intoKhronosGroup:mainfrom
AerialMantis wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
Contributor
AerialMantis
commented
Apr 19, 2024
- Remove wording which repeats "see ..." text to make it flow better.
* Remove wording which repeats "see ..." text to make it flow better.
gmlueck
reviewed
Apr 27, 2024
|
|
||
| For the name of the macro if the vendor defines the SYCL backend | ||
| outside of the Khronos SYCL group, see the following: | ||
| outside of the Khronos SYCL group. |
Contributor
There was a problem hiding this comment.
This does not read well in the rendered HTML because it looks like a sentence fragment. Can we just remove the "seealso" callout and write the sentence like:
For the name of the macro if the vendor defines the SYCL backend outside of the Khronos SYCL group, see section 6 of the core SYCL specification.
Where "section 6" is a link to that section?
This would read well, and I think it's a general improvement. Section 6 does not apply generally to the "Backend macros" section of the reference guide, so the "seealso" callout is kind of confusing. By writing it as I suggest, it's clear that section 6 applies only to that one sentence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.