Add new sample for VK_EXT_descriptor_heap#1493
Draft
SaschaWillems wants to merge 16 commits intoKhronosGroup:mainfrom
Draft
Add new sample for VK_EXT_descriptor_heap#1493SaschaWillems wants to merge 16 commits intoKhronosGroup:mainfrom
SaschaWillems wants to merge 16 commits intoKhronosGroup:mainfrom
Conversation
Both not required, as the sample uses dynamic rendering
Core since 1.1
|
In all shader examples you are using descriptor sets (for example layout (set = 1, binding = 0) uniform texture2D textureImage[2];), but according to documentation using descriptor heaps is special case like this: layout(descriptor_heap) uniform texture2D heapTexture2D[];. What the meaning of descritor heaps with using them like descriptor sets? I think this usage example is misleading. |
Collaborator
Author
|
Please read:
There is nothing misleading about this example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note: This is still a draft and not yet ready for review.
This PR adds a new sample for the recently released VK_EXT_descriptor_heap extension. It shows off different heap types (resources, samplers).
Fixes #1486
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: