Lean: avoid titlebar hover coupling that can break window controls

[constansino]

Summary\n- replace two #titlebar selectors in Lean/chrome.css with #navigator-toolbox\n- keep Lean behavior unchanged while avoiding direct dependency on titlebar hover/layout\n\n## Why\nOn Windows (observed in Zen with vertical tabs on the right), Lean could interfere with top-right window controls hitbox/behavior when mod.lean.bottom-buttons is enabled.\n\nUsing #navigator-toolbox for hover/layout scoping avoids touching titlebar-specific interaction space and prevents close/maximize button misbehavior.\n\n## Scope\n- Lean/chrome.css only\n- no preference or feature removals

[gemini-code-assist]

Summary of Changes

Hello @constansino, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a specific UI interaction bug on Windows where Lean's styling could disrupt the functionality of native window controls (like close/maximize buttons). The fix involves updating CSS selectors to scope Lean's hover and layout adjustments to the #navigator-toolbox element instead of the #titlebar, thereby preventing unintended interference with system-level UI elements.

Highlights

• CSS Selector Update: Replaced two instances of the #titlebar CSS selector with #navigator-toolbox in Lean/chrome.css.
• Window Control Fix: Resolved an issue where Lean could interfere with top-right window controls on Windows, particularly when mod.lean.bottom-buttons was enabled.
• Behavior Preservation: Ensured that Lean's intended behavior remains unchanged while eliminating direct dependency on the titlebar's hover/layout state.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• Lean/chrome.css
  • Replaced #titlebar:not(:hover) with #navigator-toolbox:not(:hover) to prevent interference with window controls.
  • Updated #titlebar to #navigator-toolbox within the @media -moz-pref("mod.lean.pinned-ext") block.

Activity

• No human activity has occurred on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively resolves an issue with window control interference by replacing #titlebar selectors with #navigator-toolbox in Lean/chrome.css. The change is well-justified in the pull request description, and the implementation is a direct and clean fix for the problem. Using #navigator-toolbox for hover and layout scoping is a sensible approach to avoid conflicts with the native window controls. The changes are consistent and improve the theme's robustness without introducing any apparent side effects. Overall, this is a solid improvement.

[KiKaraage]

Wait, I will do this in the mod store fork